Show expanded columns in gray in SQL Editor #7627
Conversation
betodealmeida
added
enhancement:request
| @@ -207,6 +207,9 @@ export default class ResultSet extends React.PureComponent { | |||
| data = results.data; | |||
| } | |||
| if (data && data.length > 0) { | |||
| const expandendColumns = results.expanded_columns | |||
There was a problem hiding this comment.
typo: expandedColumns instead of expandendColumns
There was a problem hiding this comment.
Thanks, will fix! At least the typos are consistent! :-P
Codecov Report
@@ Coverage Diff @@
## master #7627 +/- ##
==========================================
- Coverage 65.37% 65.37% -0.01%
==========================================
Files 435 435
Lines 21513 21519 +6
Branches 2378 2384 +6
==========================================
+ Hits 14064 14067 +3
- Misses 7329 7331 +2
- Partials 120 121 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #7627 +/- ##
==========================================
- Coverage 65.37% 65.37% -0.01%
==========================================
Files 435 435
Lines 21513 21519 +6
Branches 2378 2384 +6
==========================================
+ Hits 14064 14067 +3
- Misses 7329 7331 +2
- Partials 120 121 +1
Continue to review full report at Codecov.
|
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
SUMMARY
In SQL Editor, if the payload has data from expanded columns (from nested types), show the headers as grayed out, since they are not actual columns.
This PR complements #7625.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
I mocked the payload, creating two expanded columns with suffixes
aandb, and data0and1. See screenshot above.ADDITIONAL INFORMATION
REVIEWERS
@khtruong